Conversation
alt-glitch
added
type/bug
Adolanium
force-pushed
the
fix/desktop-rtl-table-direction
branch
2 times, most recently
from
June 17, 2026 15:28
6a71dd6 to
6b1d2c1
Compare
alt-glitch
added
comp/desktop
teknium1
added
sweeper:risk-compatibility
8 tasks
Markdown tables were left out of the bidi work from NousResearch#44596: an RTL table (Hebrew, Arabic, ...) kept LTR column order with headers and cells pinned to the left, because the plaintext rules only cover prose blocks and the th was hardcoded text-left. Hang dir="auto" on the table so the browser resolves column order and a single base direction from the cells' content, in practice the column headers (a box-direction property unicode-bidi:plaintext cannot set and no CSS selector can read off the script). Cells then get unicode-bidi:plaintext so a value like "-3%" or "123 units" keeps its authored order instead of being reordered by the surrounding RTL run, and text-align is pinned to the table's resolved edge via :dir() so a column's header and values stay on the same side. English tables are unchanged.
Adolanium
force-pushed
the
fix/desktop-rtl-table-direction
branch
from
September 14, 2026 23:57
6b1d2c1 to
4168242
Compare
Contributor
Author
|
I updated this on the refactored main and pushed 4168242 as one commit. I moved the fix onto the refactored resizable-table component and verified it in Chromium. Hebrew and English tables resolve correctly, and RTL resizing still works. Both desktop renderer tests and TypeScript checking passed. A headless Chromium check rendered the real component and stylesheet, verified Hebrew/English direction, column order and cell alignment, and exercised RTL column dragging. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let markdown tables resolve their direction from their content, with cell alignment following the table. Apply the change to the current resizable-table component so column dragging and persisted widths remain intact.
Validation: Both desktop renderer tests and TypeScript checking passed. A headless Chromium check rendered the real component and stylesheet, verified Hebrew/English direction, column order and cell alignment, and exercised RTL column dragging.
Updated on the refactored main at 1ab32b2, with the repair folded into one commit.